Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parser/AST from 'melody' into 'twig' #39

Merged
merged 3 commits into from
Jul 27, 2024
Merged

Conversation

zackad
Copy link
Owner

@zackad zackad commented Jul 27, 2024

Close GH-36

Hopefully this will be the last BREAKING CHANGE before version 1 release.

@zackad
Copy link
Owner Author

zackad commented Jul 27, 2024

Need to revert trailing whitespace removal on snapshot file.

@zackad zackad force-pushed the GH-36/rename-ast branch from 2b0d5e3 to 2f406e2 Compare July 27, 2024 05:28
@zackad zackad marked this pull request as ready for review July 27, 2024 05:29
@zackad zackad merged commit b96f336 into master Jul 27, 2024
2 checks passed
@zackad zackad deleted the GH-36/rename-ast branch July 27, 2024 05:39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to include the language features but specifically for Twig most of the language information can be found here: https://github.com/github-linguist/linguist/blob/39fd5e93de98de3434cb3e857c5b1972c418f8c5/lib/linguist/languages.yml#L7342
The available options can be found here: https://github.com/prettier/prettier/blob/92b8c1cda33960d6ee84c3e17eab0113b7f0f330/src/index.d.ts#L651

I am not sure what functionality you would be gaining or losing by adding or removing these options but seems like a good thing to include if they are available

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this language information is used for. If no feature affected by missing this information, I will leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename parser/AST from melody to twig
2 participants